New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop field of vtable cannot ever be null #405

Closed

oli-obk opened this issue Jul 15, 2018 · 5 comments

Contributor

oli-obk commented Jul 15, 2018

but miri thinks it can be. We should fix this to be in sync with rustc so that rustc can reuse our code

Member

RalfJung commented Jul 15, 2018

Where does miri think that?

Contributor Author

oli-obk commented Jul 15, 2018

At least in https://github.com/rust-lang/rust/blob/master/src/librustc_mir/interpret/terminator/drop.rs#L60

not sure if there are other places (vtable creation looked fine !?)

Member

RalfJung commented Aug 16, 2018

I am still not clear on what concretely you are proposing here.

Contributor Author

oli-obk commented Aug 16, 2018

Looks like miri does not think this anymore. Should have created a permalink XD

oli-obk closed this as completed

Member

RalfJung commented Aug 16, 2018

I assume you linked to https://github.com/rust-lang/rust/blob/64a75ecc8014df45b5b875c5820a0406f41ae7bb/src/librustc_mir/interpret/terminator/drop.rs#L60

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment