Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow test targets to be set via CLI args #3588

Merged
merged 4 commits into from
May 9, 2024
Merged

Conversation

RossSmyth
Copy link
Contributor

@RossSmyth RossSmyth commented May 8, 2024

Fixes #3584

I'm not a pro shell script reader as I am a Windows user, but we shall see if the CI script broke.

miri-script/src/util.rs Outdated Show resolved Hide resolved
@RossSmyth
Copy link
Contributor Author

RossSmyth commented May 8, 2024

Ah I forgot about the env var.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
miri-script/src/commands.rs Outdated Show resolved Hide resolved
miri-script/src/commands.rs Outdated Show resolved Hide resolved
miri-script/src/commands.rs Outdated Show resolved Hide resolved
miri-script/src/main.rs Outdated Show resolved Hide resolved
miri-script/src/main.rs Outdated Show resolved Hide resolved
miri-script/src/main.rs Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
miri-script/src/commands.rs Outdated Show resolved Hide resolved
miri-script/src/main.rs Outdated Show resolved Hide resolved
miri-script/src/main.rs Outdated Show resolved Hide resolved
@RalfJung
Copy link
Member

RalfJung commented May 9, 2024

@bors r+

@bors
Copy link
Collaborator

bors commented May 9, 2024

📌 Commit 3935449 has been approved by RalfJung

It is now in the queue for this repository.

bors added a commit that referenced this pull request May 9, 2024
Allow test targets to be set via CLI args

Fixes #3584

I'm not a pro shell script reader as I am a Windows user, but we shall see if the CI script broke.
@bors
Copy link
Collaborator

bors commented May 9, 2024

⌛ Testing commit 3935449 with merge ef35b0e...

@RalfJung
Copy link
Member

RalfJung commented May 9, 2024

@bors retry r+

@bors
Copy link
Collaborator

bors commented May 9, 2024

📌 Commit 07f5f8b has been approved by RalfJung

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented May 9, 2024

⌛ Testing commit 07f5f8b with merge 8b6b64e...

@bors
Copy link
Collaborator

bors commented May 9, 2024

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing 8b6b64e to master...

@bors bors merged commit 8b6b64e into rust-lang:master May 9, 2024
8 checks passed
@RossSmyth RossSmyth deleted the CliTarget branch May 9, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot add new targets after installation of toolchain
3 participants