Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo miri: add support for '--many-seeds' #3672

Merged
merged 2 commits into from
Jun 15, 2024

Conversation

RalfJung
Copy link
Member

to run the program / tests many times with different seeds: cargo miri run --many-seeds / cargo miri test --many-seeds.

@rust-lang/miri any opinion on the flag name here? Should it be -Zmiri-many-seeds or is --many-seeds fine?

Fixes #3546

@saethlin
Copy link
Member

saethlin commented Jun 13, 2024

I think --many-seeds is better. I don't see any reason to claim this is unstable/experimental by making it a -Z flag, we've been doing this many seeds thing for years and I think it has proven its value.

@RalfJung
Copy link
Member Author

All right, let's land this then. We can always adjust this later.

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 15, 2024

📌 Commit e81fa00 has been approved by RalfJung

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Jun 15, 2024

⌛ Testing commit e81fa00 with merge 60a7200...

@bors
Copy link
Collaborator

bors commented Jun 15, 2024

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing 60a7200 to master...

@bors bors merged commit 60a7200 into rust-lang:master Jun 15, 2024
8 checks passed
@RalfJung RalfJung deleted the cargo-many-seeds branch June 15, 2024 07:47
@ibraheemdev
Copy link
Member

--many-seeds doesn't seem to run integration tests, was this intentional?

@RalfJung
Copy link
Member Author

RalfJung commented Jul 3, 2024

I am not sure what you mean. Test selection is independent of this flag.

Please file an issue with reproducible instructions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for many-seeds mode to cargo miri
4 participants