Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Install tools" always runs, even when there was a cache hit #3543

Closed
RalfJung opened this issue May 3, 2024 · 4 comments
Closed

"Install tools" always runs, even when there was a cache hit #3543

RalfJung opened this issue May 3, 2024 · 4 comments
Labels
A-tests Area: affects our test suite or CI C-bug Category: This is a bug.

Comments

@RalfJung
Copy link
Member

RalfJung commented May 3, 2024

Looking at https://github.com/rust-lang/miri/actions, all the recent jobs are running this step, even though that should only happen when the cache is cold:

      - name: Install tools
        if: ${{ steps.cache.outputs.cache-hit != 'true' }}
        run: cargo install -f rustup-toolchain-install-master hyperfine

This is likely caused by #3519; things worked fine before that PR. There's a reason why I'd prefer if Github didn't subject us to updates like that all the time... they always tend to take time away from actual development...
Cc @hamirmahal

@RalfJung RalfJung added C-bug Category: This is a bug. A-tests Area: affects our test suite or CI labels May 3, 2024
@hamirmahal
Copy link
Contributor

Would using something like https://github.com/Swatinem/rust-cache help?

It’s prevented repeated downloading and compiling even when everything’s using the latest version of Node.

@RalfJung
Copy link
Member Author

RalfJung commented May 3, 2024

We shouldn't need another action, we just have to get the github native action to behave...

@RalfJung
Copy link
Member Author

RalfJung commented May 3, 2024

Ah, in https://github.com/rust-lang/miri/actions it did work properly. Maybe I was just checking the wrong actions, or it did take a bit to propagate the updated cache from #3537. Sorry for the noise!

@RalfJung RalfJung closed this as completed May 3, 2024
@hamirmahal
Copy link
Contributor

No worries!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tests Area: affects our test suite or CI C-bug Category: This is a bug.
Projects
None yet
Development

No branches or pull requests

2 participants