Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile without serde #293

Closed
RalfJung opened this issue Aug 9, 2017 · 4 comments · Fixed by #294
Closed

Compile without serde #293

RalfJung opened this issue Aug 9, 2017 · 4 comments · Fixed by #294

Comments

@RalfJung
Copy link
Member

RalfJung commented Aug 9, 2017

Can we get rid of the dependency on serde? That would enable using a stage 1 compiler to build miri, which would save me a lot of time.

@RalfJung
Copy link
Member Author

RalfJung commented Aug 9, 2017

According to @eddyb, serde is pulled in via cargo_metadata for "cargo miri". So I suggest we either make cargo miri a feature or a subcrate. Also see #166.

@oli-obk
Copy link
Contributor

oli-obk commented Aug 9, 2017

if we can make it a feature I'd prefer that.

@RalfJung
Copy link
Member Author

RalfJung commented Aug 9, 2017

Unfortunately using the stage 1 compiler still does not work. It doesn't find librustc.

@RalfJung
Copy link
Member Author

RalfJung commented Aug 2, 2018

Also the test suite needs serde to parse rustc JSON output.

So, this is unlikely to ever work without proc macros.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants