Validation update #297
Merged
Validation update #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out that tracking write locks by their lifetime is not precise enough, but for now, we don't have an alternative. Also, we need to force_allocate what we acquire or else the memory will not be in the right state.
This is not complete yet, but it is enough to make unsized-tuple-impls work.
|
Actually, I just added more tests into this one. |
oli-obk
reviewed
Aug 10, 2017
|
|
||
| fn main() { | ||
| let mut array = [1,2,3,4]; | ||
| let _x = safe::split_at_mut(&mut array, 0); //~ ERROR: in conflict with lock WriteLock |
There was a problem hiding this comment.
I ❤️ this test so much (actually the fact that it is failing)
There was a problem hiding this comment.
:) It came up when someone on reddit asked whether we could catch this, and I was like "thanks for the question -- this is a perfect sample for our test suite, once we finally have one".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out RangeMap was broken so validation didn't actually do anything. This fixes range map, and then fixes validation. Mostly. There are some tests for RangeMap now, and some tests making sure validation catches the most blatant errors. I will write more compile-fail tests.
Fixes #290