-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upstream to rustc #105
Comments
An open question is how to integrate miri's source into rustc:
@solson: have you done any work towards moving miri into rustc, or are planning on doing so any time soon? If not, do you mind if I give it a try? |
I haven't done any merging work yet, but I plan to do it relatively soon. My basic idea was to create a We'll have to get rid of our dependency on the byteorder crate before merging into rustc. |
|
I have an abstraction layer in mind, so the bulk of the code stays in the compiler and here you keep a driver and extensions to it. |
If you wait a few more days, the old makefiles are getting removed and you can just depend on crates.io. |
If I may recommend, |
Now there's a way to actually make the commits valid in this repo: make a commit to move the files in the right position and roughly the right content, on a miri branch, then merge that branch into Rust. |
There is an integration plan from last week's compiler design sprint here. |
@brson @alexcrichton Would there be serious issues if we ended up with two roots (commits with no parents) in rust-lang/rust, in order to preserve miri's history? We can do something else otherwise. |
I don't really understand what the implications of such a situation would be, but I can't think of any reason offhand why that'd be bad |
I just learned from this blog post that the Linux kernel repo has four initial commits. It doesn't seem like a big deal. One of their roots was even added by accident. |
Closing this, since Miri was in fact merged into rustc back in December in rust-lang/rust#45002, and later fully replaced the old const evaluator in rust-lang/rust#46882 just a couple weeks ago. (Thanks @oli-obk and everyone else involved!) |
Leaving things to do here so they don't get lost
@eddyb in IRC:
The text was updated successfully, but these errors were encountered: