-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support executing .bat script as a compiler on Windows #369
Comments
Seems reasonable to me to support! IIRC this is basically just testing for |
Just want to chime in here that |
Would the correct place to do this be around here? Just test for *.bat or *.cmd and if so change the command to cmd and prepend the "/c "{command}" args? |
rustc has code to execute a .bat script as a linker on Windows because it's difficult to otherwise use a script as a linker there:
https://github.com/rust-lang/rust/blob/d2048b6db375299b681d4f4728b8e7cad9f74d5f/src/librustc_codegen_llvm/back/link.rs#L59
In the Firefox build we don't currently pass compiler paths to cargo for build scripts to use because msys' path translation makes a mess of them (mostly because we're using sccache and having a space in the path breaks things):
https://searchfox.org/mozilla-central/rev/c07aaf12f13037c1f5a343d31f8291549e57373f/config/rules.mk#917
If this crate supported executing a .bat script as a compiler on Windows we could instead put everything we needed in there and simply pass the path to the .bat which ought to work.
The text was updated successfully, but these errors were encountered: