Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compile error with perl 5.34 #38

Closed
todd-richmond opened this issue Aug 26, 2021 · 3 comments
Closed

Compile error with perl 5.34 #38

todd-richmond opened this issue Aug 26, 2021 · 3 comments
Assignees
@rurban
Labels
blocking bug

Comments

@todd-richmond
Copy link

todd-richmond commented Aug 26, 2021 •
edited
Loading

PCRE2.xs no longer compiles because perl 5.34 #ifndefs out quite a few header declarations when PERL_EXT_RE_BUILD is not defined. Simple fix

*** PCRE2.xs.org 2021-08-25 21:51:37.991220377 -0700
--- PCRE2.xs 2021-08-25 21:51:54.080355417 -0700

*** 1,4 ****
--- 1,5 ----
/* -- c-basic-offset:4 -- */

  • #define PERL_EXT_RE_BUILD
    #include "EXTERN.h"
    #include "perl.h"
    #include "XSUB.h"
@rurban
Copy link
Owner

rurban commented Aug 26, 2021

There is no perl 8.34.
There is an old discontinued pcre1 8.34, which was replaced by pcre2
We wont support the old pcre.

@todd-richmond
Copy link
Author

typo - i meant perl 5.34. Latest perl with latest pcre2 10.37

@rurban rurban self-assigned this Aug 27, 2021
@rurban rurban changed the title Compile error with perl 8.34 Compile error with perl 5.34 Aug 27, 2021
@todd-richmond
Copy link
Author

fixed in commit ad0f3b9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rurban rurban

Labels
blocking bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rurban @todd-richmond