-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
devcontainer cli - support --sig-proxy=false #745
Labels
enhancement
New feature or request
Comments
|
Note the -- the sig-proxy=false argument is to prevent signals (eg. Ctrl-C) being sent along to the process inside the container. Default was to pass the signal in. |
Corresponding item in vscode devcontainer extension issues: microsoft/vscode-remote-release#6014 Note - this linked issue is for the extension, not the base devcontainer packages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What is the problem you're trying to solve?.
Running @devcontainer/cli to launch a devcontainer, the process fails at the run step due to devcontainer/cli passing the option
--sig-proxy=false
to the run action when running a single container.Describe the feature you'd like
Would like the option to either be support or ignored.
Additional context
https://github.com/devcontainers/cli/blob/f7d4c853bf8c284d784173f3e915a34d961b0b55/src/spec-node/singleContainer.ts#L396
Reproducing steps:
From a project with a .devcontainer folder/setup that has a single Dockerfile and devcontainer.json,
run:
npx devcontainer up --docker-path finch --docker-compose-path "finch compose" --workspace-folder .
The text was updated successfully, but these errors were encountered: