Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LlamaPacks: Add memary llamapack #13968

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open

LlamaPacks: Add memary llamapack #13968

wants to merge 24 commits into from
+760 −0

Conversation

seyeong-han
Copy link

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #13812

New Package?

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

  • Yes
  • No

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added new unit/integration tests
  • Added new notebook (that tests end-to-end) => Replace with Streamlit app
  • I stared at the code and made sure it makes sense

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks. => Added succinct Streamlit example
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Jun 6, 2024
logan-markewich
logan-markewich reviewed Jun 7, 2024
View reviewed changes
Copy link
Collaborator

@logan-markewich logan-markewich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine, but one high level question: Wouldn't it be more useful if there was a MemrayMemory module that implemented the memory interface in llama-index, so that it can be used with any agent?

Right now, this only really works with the agents defined here in this pack

@seyeong-han
Copy link
Author

This looks fine, but one high level question: Wouldn't it be more useful if there was a MemrayMemory module that implemented the memory interface in llama-index, so that it can be used with any agent?

Right now, this only really works with the agents defined here in this pack

Yes, you are right. @logan-markewich
We made an application that can utilize our memory modules, not only the memory modules. Users can get the ChatAgent from memary and customize it with their agent tools using llama-index.
From the application perspective, I think ours is appropriate for the llama-index-pack category.

Feel free to give me any feedback!

@kingjulio8238
Copy link

To expand on what Seyeong said, while we think it’d be great to support other agents through being a module, it does limit our flexibility for upcoming version releases and how we want to position memary in the future.

We're exploring Buffer of Thoughts to support more than just the defined ReAct agent and we plan to do that within the pack anyway. So lets go ahead with the pack.

@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. labels Jun 17, 2024
@logan-markewich
Copy link
Collaborator

We need to use python3.8+ typing, which means you can't do stuff like list[str] -- need to do List[str] and import List from typing

@seyeong-han seyeong-han mentioned this pull request Jun 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@logan-markewich logan-markewich Awaiting requested review from logan-markewich

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request]: memary added as a llama Index pack
3 participants
@seyeong-han @kingjulio8238 @logan-markewich