Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ageless War: Tooltip does not disappear after clicking upgrade button #16789

Closed
n0samu opened this issue Jun 19, 2024 · 4 comments
Closed

Ageless War: Tooltip does not disappear after clicking upgrade button #16789

n0samu opened this issue Jun 19, 2024 · 4 comments
Labels
A-avm2 Area: AVM2 (ActionScript 3) bug Something isn't working input Issues relating to user input in Flash content regression Something was working before, but is now broken

Comments

@n0samu
Copy link
Member

n0samu commented Jun 19, 2024

Describe the bug

In Ageless War, hovering over an upgrade button brings up a tooltip with info about the upgrade. As expected, moving the cursor away makes the tooltip disappear. But in Ruffle, clicking the button does not make the tooltip disappear, so it sticks around indefinitely. Here is a video demonstrating this incorrect behavior:

ruffle_agelesswar_bug.mp4

Expected behavior

In Ruffle versions 2024-04-21 and older, the tooltips behave correctly:

ruffle_agelesswar_expected.mp4

Content Location

Page URL: https://www.newgrounds.com/portal/view/567757/format/flash?emulate=flash
SWF URL: https://uploads.ungrounded.net/567000/567757_time_wars_game___FOG.swf

Affected platform

Desktop app

Operating system

Windows 10

Browser

No response

Additional information

This was regressed by #15955. Bisected to commit b9e9a3e.

@n0samu n0samu added bug Something isn't working A-avm2 Area: AVM2 (ActionScript 3) input Issues relating to user input in Flash content regression Something was working before, but is now broken labels Jun 19, 2024
@kjarosh
Copy link
Member

kjarosh commented Jun 20, 2024

A similar regression related to roll out/over events: #16684

@kjarosh
Copy link
Member

kjarosh commented Jun 20, 2024

Turns out that line's the culprit:

context.mouse_data.hovered = new;

@kjarosh
Copy link
Member

kjarosh commented Jun 21, 2024

I've decided to bypass AVM2 when firing roll over events on focus change. This issue is not easy to debug and I'm working on AVM2 support for those events anyways, so I assume that the AVM2 version is currently implemented incorrectly (which makes sense as AVM2 differentiates between keyboard and mouse focus, so perhaps it also does for keyboard and mouse hover).

@n0samu
Copy link
Member Author

n0samu commented Jul 3, 2024

Seems fixed, closing for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-avm2 Area: AVM2 (ActionScript 3) bug Something isn't working input Issues relating to user input in Flash content regression Something was working before, but is now broken
Projects
None yet
Development

No branches or pull requests

2 participants