-
-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Network#intercept silently discards unknown resource_types #313
Comments
Thanks for reporting, fixed! |
I have reported to Chrome https://bugs.chromium.org/p/chromium/issues/detail?id=1465257#c3 but I think it's gonna take them forever to address this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ferrum/lib/ferrum/network.rb
Line 190 in 277f04e
If you try to create an intercept filter with an unknown resource type, the option is silently discarded:
Instead, it should raise an exception either by letting the CDP exception bubble up:
Or, raise an exception that helps the user by tailoring the language to the Ferrum API:
It looks like
RESOURCE_TYPES
is only used to guard this value, so perhaps by letting it bubble up you wouldn't have to maintain this list anyway.This came up after trying to send
WebSocket
as a value, and finding that it wasn't accepted by CDP anyway. So maybe there's a higher-level thing that needs to change anyway.The text was updated successfully, but these errors were encountered: