Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support detailed_message for NoTypeError, InheritModuleError, NoSelfTypeFoundError and NoMixinFoundError #1280

Merged
merged 5 commits into from
Mar 20, 2023

Conversation

ksss
Copy link
Collaborator

@ksss ksss commented Mar 17, 2023

Added support for #detailed_message for four errors.
This will aid in locating the problem when an error occurs.

NoTypeFoundError

a.rbs:1:11...1:19: Could not find NotFound (RBS::NoTypeFoundError)

  type foo = NotFound
             ^^^^^^^^

InheritModuleError

a.rbs:1:12...1:18: Cannot inherit a module: Kernel (RBS::InheritModuleError)

  class Foo < Kernel
              ^^^^^^

NoSelfTypeFoundError

a.rbs:1:13...1:21: Could not find self type: NotFound (RBS::NoSelfTypeFoundError)

  module Foo : NotFound
               ^^^^^^^^

NoMixinFoundError

a.rbs:2:2...2:18: Could not find mixin: NotFound (RBS::NoMixinFoundError)

    include NotFound
    ^^^^^^^^^^^^^^^^

ref: #1166

Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

@soutaro soutaro added this to the RBS 3.1 milestone Mar 20, 2023
@soutaro soutaro added this pull request to the merge queue Mar 20, 2023
@soutaro soutaro merged commit b984cec into ruby:master Mar 20, 2023
@ksss ksss deleted the errors-1 branch March 20, 2023 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants