Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document precision=0 and ndigits=0 for converting from Float #235

Merged
merged 1 commit into from
Sep 28, 2022
Merged

Document precision=0 and ndigits=0 for converting from Float #235

merged 1 commit into from
Sep 28, 2022

Conversation

mrzasa
Copy link
Contributor

@mrzasa mrzasa commented Jul 29, 2022

  1. The documentation of Float#to_d still mentions the old default value of precision (Float::DIG). I've updated it and described what does the precision=0 mean.
  2. The description of ndigits=0 disappeared from the documentation of BigDecimal function. I've added a short mention there too.

mrkn
mrkn requested changes Sep 25, 2022
View reviewed changes
Copy link
Member

@mrkn mrkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrzasa I've left comments. Please check them.

ext/bigdecimal/bigdecimal.c Outdated Show resolved Hide resolved
lib/bigdecimal/util.rb Outdated Show resolved Hide resolved
@mrzasa
Copy link
Contributor Author

mrzasa commented Sep 27, 2022

I've removed mentions of dtoa from the docs.

@mrkn
Copy link
Member

mrkn commented Sep 28, 2022

@mrzasa Thank you very much.

@mrkn mrkn merged commit 4f0894c into ruby:master Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olleolleolle olleolleolle olleolleolle left review comments

@mrkn mrkn mrkn requested changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrzasa @mrkn @olleolleolle