Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced RDoc for BigDecimal #209

Merged
merged 8 commits into from
Dec 21, 2021
Merged

Enhanced RDoc for BigDecimal #209

merged 8 commits into from
Dec 21, 2021

Conversation

BurdetteLamar
Copy link
Member

Treated:

  • #+
  • #-
  • #<
  • #<=
  • #>
  • #>=
  • #+@
  • #-@
  • #add
  • #mult
  • #abs
  • #**
  • #BigDecimal

Plus some minor tweaks to previous updates.

@BurdetteLamar
Copy link
Member Author

@mrkn, this is big, I know. (I got carried away!) We can work on this piecemeal if you like.

@mrkn
Copy link
Member

mrkn commented Dec 2, 2021

@BurdetteLamar Now I'm working on some bug fixes and improvements of bigdecimal for the Ruby 3.1 release.
I'll check this after finishing these works.

ext/bigdecimal/bigdecimal.c Outdated Show resolved Hide resolved
Remove the instance number of `Float::DIG`.
Add BigDecimal call-seq without ndigits.
ext/bigdecimal/bigdecimal.c Outdated Show resolved Hide resolved
Replace the word sum with value or result in the description of BigDecimal().
ext/bigdecimal/bigdecimal.c Outdated Show resolved Hide resolved
Remove the instance value of Float::DIG.
ext/bigdecimal/bigdecimal.c Outdated Show resolved Hide resolved
Fix mis-description of precision
Fix the description of precision determination
Add the description of the precision in the Rational case.
@mrkn mrkn merged commit acabb13 into ruby:master Dec 21, 2021
mrkn added a commit to mrkn/ruby that referenced this pull request Dec 23, 2021
* Enhanced RDoc for BigDecimal

* Update ext/bigdecimal/bigdecimal.c

Remove the instance number of `Float::DIG`.

* Update ext/bigdecimal/bigdecimal.c

Add BigDecimal call-seq without ndigits.

* Update ext/bigdecimal/bigdecimal.c

Replace the word sum with value or result in the description of BigDecimal().

* Update ext/bigdecimal/bigdecimal.c

Remove the instance value of Float::DIG.

* Update ext/bigdecimal/bigdecimal.c

Fix mis-description of precision

* Update ext/bigdecimal/bigdecimal.c

Fix the description of precision determination

* Update ext/bigdecimal/bigdecimal.c

Add the description of the precision in the Rational case.

ruby/bigdecimal@acabb132a4

Co-authored-by: Kenta Murata <[email protected]>
matzbot pushed a commit to ruby/ruby that referenced this pull request Dec 23, 2021
* Enhanced RDoc for BigDecimal

* Update ext/bigdecimal/bigdecimal.c

Remove the instance number of `Float::DIG`.

* Update ext/bigdecimal/bigdecimal.c

Add BigDecimal call-seq without ndigits.

* Update ext/bigdecimal/bigdecimal.c

Replace the word sum with value or result in the description of BigDecimal().

* Update ext/bigdecimal/bigdecimal.c

Remove the instance value of Float::DIG.

* Update ext/bigdecimal/bigdecimal.c

Fix mis-description of precision

* Update ext/bigdecimal/bigdecimal.c

Fix the description of precision determination

* Update ext/bigdecimal/bigdecimal.c

Add the description of the precision in the Rational case.

ruby/bigdecimal@acabb132a4

Co-authored-by: Kenta Murata <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants