Skip to content
This repository has been archived by the owner on Sep 22, 2022. It is now read-only.

Transfer transaction may fail when chain reorgantzaion happens #34

Open
darcher-framework opened this issue Dec 24, 2020 · 1 comment
Open

Comments

@darcher-framework
Copy link

In usual cases, there are two transaction we need to send to use multisender.
The first one is to approve tokens for multisender contract and the second one is to actually do the transfer.

However, cases can happen where chain organization happens when approve transaction is reverted, but multisender has already make user send the second transfer transaction at this time, which will definitely fail because tokens are not approved.

This will cause users to lose transaction fee for transaction failure.

@rstormsf
Copy link
Owner

rstormsf commented Dec 25, 2020

in theory yes, in practice, it never happened during 3 years of production operational experience.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants