Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider formulating NpcVariant as EmbeddedNpc #67

Open
rsek opened this issue Aug 12, 2024 · 0 comments
Open

Consider formulating NpcVariant as EmbeddedNpc #67

rsek opened this issue Aug 12, 2024 · 0 comments

Comments

@rsek
Copy link
Owner

rsek commented Aug 12, 2024

Complicating factor: Datasworn's constants assume that an embedded type dictionary uses the same key as the primary type dictionary in the RulesPackage object. That'd mean that NPC variants live in Npc#npcs rather than Npc#variants, which I don't care for.

It's possible to change that, but would mean adding some additional constants and checks to e.g. IdParser

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant