Add shell script checks

Makefile

@@ -11,7 +11,9 @@ The following make targets are available:
  clean Cleanup build directories.
  dist Build distribution files.
  help Show this text.
+ push Push to all configured Git remotes.
  pypi Upload distribution files to PyPI.
+ schk Shell script check.
  stest Run sandboxed Python tests (disables network tests).
  test Run all Python tests and generate coverage report.
 
@@ -43,3 +45,9 @@ stest:
 
 test:
  env NETWORK_TESTS=1 $(unittest) coverage
+
+push:
+ for _r in $(shell git remote); do git push $$_r; done; unset _r
+
+schk:
+ shellcheck -x contrib/*.sh

contrib/package.sh

@@ -10,7 +10,7 @@ set -euo pipefail
 
 function usage() {
  local bn
- bn="$(basename $0)"
+ bn="$(basename "$0")"
  echo "Usage: ${bn} {clean | dist | pypi}" >&2
  echo " ${bn} setver {version}" >&2
  exit 1
@@ -41,11 +41,11 @@ arg="${1}"
 shift
 case "${arg}" in
  clean)
- do_${arg}
+ do_"${arg}"
  ;;
  dist|setver|pypi)
  . .venv/bin/activate
- do_${arg} "$@"
+ do_"${arg}" "$@"
  ;;
  *)
  usage

contrib/unittest.sh

@@ -25,7 +25,7 @@ CONF='tests/tests.conf'
 sed -i'' -e "s,^db_url.*,db_url = sqlite:https:///${DB}," $CONF
 
 function usage() {
- echo "Usage: $(basename $0) [coverage]" >&2
+ echo "Usage: $(basename "$0") [coverage]" >&2
  exit 1
 }