You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think this is problematic as it should check in a more general way, to handle also Nop and zero values. In my tests I found race conditions because I was reusing same global nop-logger. I think a better check would be something like it was done in #617. Do you agree? I can make a PR.
The text was updated successfully, but these errors were encountered:
logger.UpdateContext
checks for disabled logger:I think this is problematic as it should check in a more general way, to handle also
Nop
and zero values. In my tests I found race conditions because I was reusing same global nop-logger. I think a better check would be something like it was done in #617. Do you agree? I can make a PR.The text was updated successfully, but these errors were encountered: