Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.19.1.1: source and patrches listed in NoSoure: ans NoPatch: are not removed when is used --rmsource #3037

Open
kloczek opened this issue Apr 15, 2024 · 2 comments
Assignees

Comments

@kloczek
Copy link
Contributor

kloczek commented Apr 15, 2024

Yeah .. looks like that remove files listed in NoSource: NoPatch: is not performed when --rmsource is used.

@pmatilai pmatilai self-assigned this Apr 17, 2024
@pmatilai
Copy link
Member

This gets kinda philosophical: --rmsource removes sources, but is a "nosource" a source? The name seems to indicate it's not.

@pmatilai
Copy link
Member

We discussed this at some length, and actually the current behavior seems correct.

Nosource items are not managed by rpm in any way: they don't get pulled into src.rpm's, and if you want to rebuild an src.rpm utilizing nosources, you need to manually copy any nosource items in place. It's then only consistent that rpm doesn't remove them either.
Plus, by definition they are non-sources, so it seems consistent with that as well.
This just needs to be documented.

Thanks for the report btw.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

2 participants