rpmbuild should error out on conflicting %exclude directive

[voxik]

Given this .spec file:

Summary: summary
Name: newpackage
Version: 1
Release: 1%{?dist}
License: MIT

%description

%install
mkdir -p %{buildroot}%{_tmppath}
echo "foo" > %{buildroot}%{_tmppath}/f

%files
%exclude %{_tmppath}/f
%{_tmppath}/f

%changelog
* Tue Jan 16 2024 Vít Ondruch <[email protected]>
- newpackage

where the file is excluded first and included later, I'd expect that the file will be included in the package, but that is not the case:

$ rpm -qpl /var/lib/mock/fedora-rawhide-x86_64/result/newpackage-1-1.fc40.x86_64.rpm 
(contains no files)

Please note that I have faced the issue when I was trying to remove some subpackages, but keep the files section as similar to the original state as possible.

[pmatilai]

You're instructing rpm to both exclude and include a file. It cannot possibly do both, so the only reasonable course of action is erroring out.

[voxik]

the only reasonable course of action is erroring out.

Shall I open separate ticket?

[pmatilai]

Hmm, it seems I misread the report because I thought that's what was happening, I guess the strange ticket summary set the stage for strange ideas what will follow.

[voxik]

I have not really wanted to suggest this should be prohibited / reported as an error.

But since duplicates are already detected and reported, reporting this would be in line with that and possibly prevented possible surprises, so that is acceptable.