Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-detect systemd-sysusers(8) in tests #2592

Open
dmnks opened this issue Jul 31, 2023 · 2 comments
Open

Auto-detect systemd-sysusers(8) in tests #2592

dmnks opened this issue Jul 31, 2023 · 2 comments
Labels
test Testsuite-related

Comments

@dmnks
Copy link
Contributor

dmnks commented Jul 31, 2023

Since commit 2bdd7d7, we no longer test the systemd-sysusers(8) implementation shipped by systemd. This also minimizes the local test tree (e.g. mktree.fedora) quite a bit since we no longer have to pull in the whole of systemd.

However, in the CI (i.e. mktree.podman), we might, just to have that use case covered. We can do that simply by detecting the presence of /usr/bin/systemd-sysusers in the respective test in rpmi.at (or perhaps in atlocal?) and using that if present.

@pmatilai pmatilai added the test Testsuite-related label Sep 14, 2023
@pmatilai
Copy link
Member

pmatilai commented Nov 8, 2023

The reason I'm asking you to triage your own ticket 😄 is: did this situation change with the recent test-suite oci image stuff?

@dmnks
Copy link
Contributor Author

dmnks commented Nov 29, 2023

Actually, this didn't change much with the full move to OCI images. However, systemd-sysusers is installed into the image which means we can trivially use it in the test. I'm thinking we should probably just enhance the current test to run twice, setting %__systemd_sysusers to @__SYSTEMD_SYSUSERS@ the second time. Or just duplicate the test. In any case, Todo material...

@dmnks dmnks removed their assignment Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Testsuite-related
Projects
Status: Todo
Development

No branches or pull requests

2 participants