diff --git a/src/module/actor/base.ts b/src/module/actor/base.ts index a3bc6cb234c..5fb9664aac6 100644 --- a/src/module/actor/base.ts +++ b/src/module/actor/base.ts @@ -1722,9 +1722,7 @@ class ActorPF2e { Hooks.on("closeCombatTrackerConfig", async (_app, $html): Promise => { - const newIcon = String($html.find('input[name="deathIcon"]').val()).trim(); + const html = $html[0]; + const newIcon = htmlQuery(html, "file-picker")?.value; if (newIcon && newIcon !== game.settings.get("pf2e", "deathIcon")) { await game.settings.set("pf2e", "deathIcon", newIcon); } const currentDeadAtZero = game.settings.get("pf2e", "automation.actorsDeadAtZero"); - const newDeadAtZero = String($html.find('select[name="actorsDeadAtZero"]').val()); - if (currentDeadAtZero !== newDeadAtZero) { + const newDeadAtZero = htmlQuery(html, "select[name=actorsDeadAtZero]")?.value; + if (newDeadAtZero && currentDeadAtZero !== newDeadAtZero) { await game.settings.set("pf2e", "automation.actorsDeadAtZero", newDeadAtZero); } }); diff --git a/src/scripts/hooks/render-combat-tracker-config.ts b/src/scripts/hooks/render-combat-tracker-config.ts index b5978a96169..239fbdcad2e 100644 --- a/src/scripts/hooks/render-combat-tracker-config.ts +++ b/src/scripts/hooks/render-combat-tracker-config.ts @@ -13,6 +13,11 @@ export const RenderCombatTrackerConfig = { values: { deathIcon: game.settings.get("pf2e", "deathIcon"), actorsDeadAtZero: game.settings.get("pf2e", "automation.actorsDeadAtZero"), + deadAtZeroOptions: [ + { value: "both", label: "PF2E.SETTINGS.Automation.ActorsDeadAtZero.Both" }, + { value: "npcsOnly", label: "PF2E.SETTINGS.Automation.ActorsDeadAtZero.NPCsOnly" }, + { value: "neither", label: "PF2E.SETTINGS.Automation.ActorsDeadAtZero.Neither" }, + ], }, }); const tempElem = document.createElement("div"); diff --git a/static/templates/sidebar/encounter-tracker/config.hbs b/static/templates/sidebar/encounter-tracker/config.hbs index 58f3fd7e56c..269e9af5ff6 100644 --- a/static/templates/sidebar/encounter-tracker/config.hbs +++ b/static/templates/sidebar/encounter-tracker/config.hbs @@ -2,8 +2,7 @@
- {{filePicker target="deathIcon" type="imagevideo"}} - +

{{localize "PF2E.SETTINGS.DeathIcon.Hint"}}

@@ -11,11 +10,7 @@

{{localize "PF2E.SETTINGS.Automation.ActorsDeadAtZero.Hint"}}