-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is it a bug to increase the best_ind in decoder_rnn.py? #56
Comments
hi there, good question! looking at it again, I'm not sure what I was doing there. unfortunately I don't have too much time to investigate this at the moment, but it's possible there was a bug in the code. Note that this was the code responsible for all the experiments in the paper, so fixing this might increase performance - if it was indeed a problem. curious to hear your thoughts!! Rowan |
Hi, |
https://github.com/rowanz/neural-motifs/blob/master/lib/lstm/decoder_rnn.py#L227
It seems that the best_ind is already in the 1-150. Why do you add best_ind by 1 here?
The text was updated successfully, but these errors were encountered: