Add setting to not query daily stats #8142
Conversation
eb1791b
to
0e00f0c
Compare
0e00f0c
to
7ca4d24
Compare
There was a problem hiding this comment.
You did what we discussed!
But looking at this I got a bit confused and torn if this is the right approach. What do we want to achieve with this PR?
- To have a way to not query daily stats automatically if we want to. We can decide whether this is gonna be default or not, but that's another question.
- To be able to query them manually if we want to.
As far as I know daily stats do not get populated by any of the long running tasks right?
So seeing that our current function has the "only_cache" argument already ... isn't this setting redundant for the backend?
Couldn't we just make this a frontend only setting? The frontend would query with only_cache: True at the page load. And then depending on if the setting is on it would also do an only_cache: False to trigger a remote query only if this setting is on.
And if the user ever wanted to manually refresh the daily stats, irrespective of the setting value they should press the "refresh" button on daily stats and have them refresh. This requires a separate daily stats refresh button if there is none at the moment.
That's on the setting.
Now I also have a question on the new daily stats API. Does it return data only for completed days? I hope yes. Otherwise we may have problems.
| @@ -654,6 +654,7 @@ Getting or modifying settings | |||
| :resjson int oracle_penalty_threshold_count: The number of failures after which an oracle is penalized. Default is 5. | |||
| :resjson int oracle_penalty_duration: The duration in seconds for which an oracle is penalized. Default is 1800. | |||
| :resjson bool auto_create_calendar_reminders: A boolean denoting whether reminders are created automatically for calendar entries based on the decoded history events. Default is ``true``. | |||
| :resjson bool query_daily_stats_from_beaconchain: A boolean denoting whether we are allowed to query beaconchain for daily stats. Default is ``true``. | |||
There was a problem hiding this comment.
Some clarification.
| :resjson bool query_daily_stats_from_beaconchain: A boolean denoting whether we are allowed to query beaconchain for daily stats. Default is ``true``. | |
| :resjson bool query_daily_stats_from_beaconchain: A boolean denoting whether we are allowed to query beaconchain for daily stats. The reason for the existence of the setting is to limit the rate limiting as this information is purely for informatonal purposes. Default is ``true``. |
Also shouldn't we mark it as false by default? To limit rate limiting by default?
As far as I understand in the UI we can still just press refresh on daily stats on demand if we want more data to fetch on demand.
|
Closing since we are adding it as a frontend setting |
Closes #8120