-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new release team for ROS 2 FlexBE #289
Comments
I think its entirely up to you. I'd propose either:
The advantages of the first option are that you don't have to worry about mistargeted pushes at the expense of slight confusion that "ros2-gbp" is used for ROS Noetic releases. But there's no technical reason not to do so. I've opened #293 and will wait to merge it or import release repositories pending your preference above and the merging of ros/rosdistro#37823 |
Would it be an option to combine by doing option 2, and then recreating the noetic release on ros2-gdp vs. importing the entire history. Then I can archive the old one after the changes take effect. Otherwise, I'm inclined to just do option 2. |
@nuclearsandwich - Added rosdistro source link |
Is there anything missing that is preventing #293 from being merged so that I can prepare the release? I have the naming approvals from rosdistro linked above: |
What reason is there not to import the Noetic history?
Keeping the release history for noetic together is a much nicer experience for someone who wants to review the release history of the package.
Nope with the links you mention we're now ready to proceed pending a decision on importing noetic history or starting fresh with ROS 2 releases only. |
I planned to import full history of noetic just not the obsolete branches
Let's roll with this plan. Thanks.
|
To clarify, my intent was to If that is not sufficient and you want to mirror the entire repo with obsolete branches before noetic, let me know. I'd lean toward just doing option 2 in that case and only using this repo for ROS 2, but happy to comply with whatever you want to move this forward. |
Touching base on this again. There is an issue with flexbe_app release identified by @sloretz FlexBE/flexbe_app#90 I do NOT plan to push a flexbe_app release in the near term, but would like to get the humble release for flexbe_behavior_engine out the door. |
Got it. Thanks for the clarification. I think that a |
Whatever you suggest to move this forward.
I take "admin" to mean @nuclearsandwich or someone will handle the initial push then. Let's just mirror the flexbe_behavior_engine-release. |
#293 is being deployed now. Once it is I'll mirror flexbe_behavior_engine-release and report back here
Yep that's generally me although there are others in case something happens to me. |
This change has been deployed and github.com/ros2-gbp/flexbe_behavior_engine-release mirrors https://github.com/FlexBE/flexbe_behavior_engine-release |
@nuclearsandwich questions:
|
This is a side effect of the fact that in git the 'default' branch is just the first one pushed. So when mirroring to an empty repository the first branch is often the lexicographically topmost one and thus becomes the default. I've switched it to bloom's config branch which is
Release team members have |
Submitted PR for naming review submit flexbe for ROS 2 naming review prior to creating release repos ros/rosdistro#37823
Proposed names of release repos:
url: https://github.com/ros2-gbp/flexbe_app-release.git
url: https://github.com/ros2-gbp/flexbe_behavior_engine-release.git
There are already a ROS 1 release repos created:
https://github.com/FlexBE/flexbe_app-release
https://github.com/FlexBE/flexbe_behavior_engine-release
But I planned to create separate ones on the ros2-gbp site .
I'm listing them below for completeness, but not sure we want to import versus just create new.
If there are any existing release repositories which should have their contents imported into the ros2-gbp organization, list and link to them here.
Leave the checkbox unchecked. The ros2-gbp administrator will check the box when they have completed the repository import.
-->
flexbe_app
flexbe_behavior_engine
Team members
The text was updated successfully, but these errors were encountered: