Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable dev jobs for rosbag2_bag_v2 #25505

Merged
merged 2 commits into from
Jun 17, 2020
Merged

disable dev jobs for rosbag2_bag_v2 #25505

merged 2 commits into from
Jun 17, 2020

Conversation

Karsten1987
Copy link
Contributor

given that dev jobs can't source a ROS1 distro beforehand, it makes sense to disable the dev jobs for the rosbag2_bag_v2 packages as they rely on roscpp to be found.

Copy link
Member

@dirk-thomas dirk-thomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same fix is needed for all active distros - including Dashing and Eloquent.

foxy/distribution.yaml Outdated Show resolved Hide resolved
Signed-off-by: Karsten Knese <[email protected]>
@Karsten1987
Copy link
Contributor Author

thank you all for your help.
I don't have permissions to merge.

@dirk-thomas dirk-thomas merged commit dd2bd0c into ros:master Jun 17, 2020
@Karsten1987 Karsten1987 deleted the rosbag2_bag_v2_disable_dev branch June 17, 2020 17:49
sloretz pushed a commit that referenced this pull request Aug 5, 2020
* disable dev jobs for rosbag2_bag_v2

Signed-off-by: Karsten Knese <[email protected]>

* test_commits: false

Signed-off-by: Karsten Knese <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants