Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release for Lunar #11

Closed
tfoote opened this issue Mar 20, 2017 · 4 comments
Closed

Release for Lunar #11

tfoote opened this issue Mar 20, 2017 · 4 comments

Comments

@tfoote
Copy link
Contributor

tfoote commented Mar 20, 2017

bfl has appeared on the blocking list for lunar release: http:https://repositories.ros.org/status_page/blocked_releases_lunar.html?q=label%3D%22UNBLOCKED%22&s=6&r=1

The svn server dissapeared for Kinetic so we rereleased using the existing imported 0.7 version in this repo: 7b4f454

However now I see that there's a 0.8 release listed with a tarball: http:https://www.orocos.org/orocos/source-code-2 and a new github repo: https://github.com/toeklk/orocos-bayesian-filtering is linked from the home page. It's not clear where the best source would be for Lunar. The new git repo has a slightly different layout with the orocos-bfl package in a subdirectory.

@toeklk might you have a suggestion whether it's worth moving forward to 0.8 for ROS Lunar or just repackaging 0.7 for now?

@mikaelarguedas FYI Re Lunar progress

@toeklk
Copy link

toeklk commented Mar 21, 2017

Hi,

I'm not a ros user, so it's hard for me to judge the ros-suitability of a particular BFL version. Still,

  • 0.8 has some bugfixes wrt 0.7, and improved compatibility for non-gnu compilers IIRC
  • (from a quick diff) 0.8.99 (the version I recently imported to github) has more bugfixes, an updated README file and NIS value calculation for the Kalman Filter

Note that there are various 'forks' available (probably partly due to the fact that BFL has been moved far too late to github) such as

The latter are based on the 0.8 release, hence they probably miss some of the bugfixes which are present in 0.8.99

Ideally, somebody would offer me a pull request for the eigen matrix library, such that I can integrate it and produce a 0.9.0 version...

@tfoote
Copy link
Contributor Author

tfoote commented Mar 21, 2017

Thanks for the feedback I opened: orocos/orocos-bayesian-filtering#1 as a follow up but I'm not going to have time to follow up since this is not a core dependency.

@mikeferguson do you mind if I just release 0.7 forward w/o any changes?

@mikeferguson
Copy link
Contributor

@tfoote AFAIK the only thing using BFL in ros is robot_pose_ekf -- which is really only useful on PR2, which is EOL. So yeah, let's just put the same 0.7 out (I don't want to patch robot_pose_ekf anyways).

@tfoote
Copy link
Contributor Author

tfoote commented Mar 23, 2017

ros/rosdistro#14298

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants