Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

email address? #52

Open
maelle opened this issue Nov 14, 2018 · 1 comment
Open

email address? #52

maelle opened this issue Nov 14, 2018 · 1 comment

Comments

@maelle
Copy link
Contributor

maelle commented Nov 14, 2018

Does the package really use the user's email address? I don't think so?

In the README it could be advised to either do the git settings your recommend, or to set the GITHUB_USERNAME environment variable (that'll still be needed if the email address isn't public on GitHub anyway), or maybe it's just easier to refer to whoami docs?
@annakrystalli
Copy link
Collaborator

Yes adding this option to the docs is a good idea. Will address when I do the README/vignette overhaul

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@annakrystalli @maelle