Fix source map paths #1496
Merged
Fix source map paths #1496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have some users on the forums testing this out. I'll test it out personally here in a second. In the mean time: @swalkinshaw is probably going to make you squash your two commits into one. 👮 I've tagged this for release in 8.2.2 as well. |
|
Thanks for your reply 👍 Sorry that I didn't do an interactive rebase btw! |
|
I just squashed the two commits into one. |
|
@retlehs good to go |
|
@martinvd What do you think about this? https://discourse.roots.io/t/error-loading-source-scss-files/4060/5?u=austin |
|
@austinpray That's interesting. I'll have a look into this asap and will try to reproduce it as well and then respond in the Roots Discourse issue. |
|
Thanks bud! |
|
np 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets the gulp-sourcemaps
sourceRootoption, now pointing to the right locations of the source maps. Since it was not set, it was pointing to the default/source/folder, which is not the right folder.