-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP 8.2 Compatibility #590
Labels
Rank: 2 - Major
Tackle when there are no actionable Critical requests.
Status: 3 - Construction
The request is being worked on.
Milestone
Comments
1 task
I wrote a test to validate this in commit 8d5fb81. The output on PHP 8.2 is as follows...
This validates, the deprecation warning. |
This was referenced Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Rank: 2 - Major
Tackle when there are no actionable Critical requests.
Status: 3 - Construction
The request is being worked on.
With the release of PHP 8.2 there were a number of things that were deprecated. Fortunately, only one appears to impact the Rollbar PHP package. It is Deprecate dynamic properties.
We use dynamic properties to keep track of errors and exceptions that were explicitly passed to the Rollbar or "caught" by the handlers via the
isUncaught
property.This can easily be fixed in both our error handler and fatal error handler since we use our own
ErrorWrapper
class, and we can just declare the property in it. For the exception handler we will need to think through how we handle it.The text was updated successfully, but these errors were encountered: