Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rollbar/rollbar-gem
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v3.4.2
Choose a base ref
...
head repository: rollbar/rollbar-gem
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
  • 11 commits
  • 18 files changed
  • 3 contributors

Commits on Dec 19, 2023

  1. Fix warning: attribute accessor as module_function (#1138)

    When Running rspec with --warnings enabled a warning is emitted by the
    rollbar gem.
    
    ```
    $ rspec --warnings
    /my/path/ruby-3.2.2/gems/rollbar-3.4.1/lib/rollbar/json.rb:8: warning: attribute accessor as module_function
    ```
    
    This is caused by the line
    ```
    attr_writer :options_module
    ```
    Within [lib/rollbar/json.rb](https://github.com/rollbar/rollbar-gem/blob/8c6a9e94629c0a8b964f0a3b13eab742c3800841/lib/rollbar/json.rb#L8)
    
    The line was introduced here, when there was a more complicated way of configuring the json parser.
    
    e33f10e#diff-9e64389290ff8e4e50cba9436521333bdd3307baa63ed84b74f0f9b28a6cfceaR13
    
    However in 2019 this code was removed, and replaced with Ruby's JSON module
    
    de45e80#diff-9e64389290ff8e4e50cba9436521333bdd3307baa63ed84b74f0f9b28a6cfceaL39-L41
    
    But the attr_writer was (accidentally?) not removed.
    
    As the `options_module` attribute writer is not documented or referenced anywhere else in the project I believe it can be removed.
    
    This commit removes the unused `attr_writer` and fixes the warning.
    
    Fixes: #1108
    GeoffKarnov committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    54b192d View commit details
    Browse the repository at this point in the history
  2. Option to enable scoped block for DelayedJob plugin (#1087)

    When enabled, this adds job data to any Rollbar reporting that happens
    within the job, and prevents changes to the scope from polluting the
    global scope for other jobs.
    
    Co-authored-by: Walt Jones <[email protected]>
    iangreenleaf and waltjones committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    4556623 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2024

  1. Fix ActionMailer plugin to add rescue_from to the correct class (#1143

    )
    
    * make ActiveJob plugin a true plugin, with disable
    
    * add rescue_from to ActionMailer::Base, not MailDeliveryJob
    
    * test for Rails 6+ first. (DeliveryJob is always defined.)
    
    * limit DeliveryJob tests to Rails < 6.x
    
    * update test app config for rails 6+
    
    * handle undefined job_id
    
    * refactor to test both DeliveryJob and MailDeliveryJob
    waltjones committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    dc2a396 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0eced3d View commit details
    Browse the repository at this point in the history
  3. Release v3.5.0 (#1144)

    waltjones committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    cae70e4 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2024

  1. Configuration menu
    Copy the full SHA
    9c00fdb View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2024

  1. Release v3.5.1 (#1147)

    waltjones committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    063b416 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2024

  1. Configuration menu
    Copy the full SHA
    bf3b921 View commit details
    Browse the repository at this point in the history
  2. Release v3.5.2 (#1150)

    waltjones committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    9e81cd6 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2024

  1. Enable Rails 7 error reporter via Rollbar config (#1161)

    * allow both hash syntaxes
    
    * enable Rails 7 error reporter via Rollbar config
    
    * initialize logger base class
    
    * use Logger version
    
    * apply capture_uncaught config to rails error subscriber
    waltjones committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    f9d0be7 View commit details
    Browse the repository at this point in the history
  2. Release v3.6.0 (#1162)

    waltjones committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    c4edf7e View commit details
    Browse the repository at this point in the history
Loading