-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stack_data, executing, and pure_eval #350
Comments
Closing due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi! I've recently created a few libraries that are helpful for extracting information from frames and tracebacks, and I think they could be very useful to rollbar.
executing
can identify the exact AST node being executed by a frame in many cases. It's always disappointed me that Python only points to a line in each frame in tracebacks, especially when the expression/statement at fault spans many lines. Sometimes it can be really hard to interpret. Currently executing is used in IPython (in master, unreleased) to highlight the node, here's what it looks like:executing
can also infer a function__qualname__
from a code object, meaning your traceback can saylorem/ipsum.py in MyClass.__init__ at line 123
instead of just__init__
, which is much more informative.pure_eval
can safely evaluate certain AST nodes without side effects, so that if the source for a frame contains expressions likeself.foo
andbar[key]
their values can often be shown alongside plain variables.stack_data
collects data from tracebacks for the purpose of formatting and displaying them. It usesexecuting
andpure_eval
and also provides a lot of functionality of its own. I integratedstack_data
into IPython which allowed removing a lot of flaky custom introspection code, fixing several bugs and making the code more maintainable.stack_data
identifies the locations of variables and evaluated expressions in the source lines. An intelligent UI could use this, for example, to allow the user to hover over a variable in source code to see its value rather than scroll through a list to find it.I'll be honest, I've never used rollbar before (in fact I only just learned about it) so I don't know exactly what would make sense. But I made a similar issue on sentry (getsentry/sentry-python#748) and integrated a couple of these features in there and they seemed pretty happy, particularly with pure_eval. Seeing as you guys are an alternative to sentry, I thought it made sense to give you a heads up. I don't actually have time to integrate these myself, but I'd be happy to help with any questions you have.
The text was updated successfully, but these errors were encountered: