Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve colors #21

Open
innomerphey opened this issue Jul 27, 2020 · 1 comment
Open

Improve colors #21

innomerphey opened this issue Jul 27, 2020 · 1 comment

Comments

@innomerphey
Copy link

Hey, thank you for the great extension.
I found that some of the primary colors don't match the originals. This may cause eye fatigue. I feel a little discomfort from such bright yellow and white. Please, take a look at these pictures bellow.

Webstorm:
idea

VS Code:
vs

Have these colors been changed on purpose?

@rokoroku
Copy link
Owner

rokoroku commented Aug 5, 2020

Thank you for feedback.

The initial purpose when I creating this theme was to port IntelliJ's javascript color scheme into vscode.
So I've picked string, function and variable color from IntelliJ's color scheme and write them onto vscode's default dark theme, and accepted community's PR so far. Maybe I added my own typescript type token scheme by using blue color.

image
image

And I noticed that the yellow color in html color scheme is slightly different from the yellow color in javascript color scheme. So next time maybe I have to add html-specific rule to achieve what you suggest.

And I also noticed that I didn't apply the global foreground color (the white color you mentioned) too. This gonna be patched too :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants