Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add param count check #150

Closed
rokath opened this issue Sep 24, 2021 · 6 comments
Closed

Add param count check #150

rokath opened this issue Sep 24, 2021 · 6 comments
Assignees
Labels
enhancement New feature or request RegEx Parser issue *Trice* tool
Milestone

Comments

@rokath
Copy link
Owner

rokath commented Sep 24, 2021

When during trice u a trice statement ist evaluated, the format specifier count should match the param count and _n, if specified. If not, report an error and write #error in front of trice statement. This allows generally not to use _n.

@rokath rokath added enhancement New feature or request RegEx Parser issue labels Sep 24, 2021
@rokath rokath self-assigned this Sep 24, 2021
@rokath rokath added this to the version 1.0 milestone Sep 24, 2021
@rokath
Copy link
Owner Author

rokath commented Oct 27, 2021

See #157 when solvng this.

@th-sabik
Copy link
Contributor

th-sabik commented Nov 1, 2021

A runtime check exists now, but a pre-compiletime check (trice -u) is higher quality.

@rokath
Copy link
Owner Author

rokath commented May 21, 2022

Merged with #291

@rokath rokath closed this as completed May 21, 2022
@rokath rokath reopened this May 23, 2022
@rokath
Copy link
Owner Author

rokath commented May 11, 2023

For example this line caused a problem only at runtime:

trice( iD( 1278), "diag:RTT0_bytesInBufferMax=%u, RTT0_writeSpaceMin\n", RTT0_bytesInBufferMax, RTT0_writeSpaceMin );

@rokath
Copy link
Owner Author

rokath commented Aug 17, 2024

Write tests for trice i -addParamCount and trice u -addParamCount for TRICE, TRICE8,... ,trice64.

@rokath
Copy link
Owner Author

rokath commented Aug 23, 2024

parameter count check is implemented in v0.67.0

@rokath rokath closed this as completed Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request RegEx Parser issue *Trice* tool
Projects
None yet
Development

No branches or pull requests

2 participants