Uploading using url through the API seems broken

[leonluc-dev]

When using the api to upload an image like this https://myserver.com/api/1/upload?key=api-key&format=json&source=https%3A%2F%2Fexample.com%2image.jpg the api cannot process the image.

This seems related to this particular bit of code:

chevereto-free/app/routes/route.api.php

Lines 61 to 63 in 0dce5d5

	case G\is_image_url($source) || G\is_url($source):
	$sourceQs = G\getQsParams()['source'];
	$source = isset($sourceQs) ? $sourceQs : $source;

At line 61 the $source variable is already plaintext (url decoded). However, the G\getQsParams()['source']; returns an url encoded value and sets the source variable to it.
This is causing the CHV\Image::uploadToWebsite($source); call to return "invalid file type" (since it cannot handle url encoded values)

[rodber]

Try using POST.

[leonluc-dev]

POST using a x-www-form-urlencoded body with the same params does work. Thanks for the tip!

I wasn't aware POST was required due to the docs mentioning support for GET