Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Windows Containers #287

Open
Rob-B-NAIT opened this issue Jun 12, 2024 · 1 comment
Open

Add support for Windows Containers #287

Rob-B-NAIT opened this issue Jun 12, 2024 · 1 comment

Comments

@Rob-B-NAIT
Copy link

We have Windows based worker nodes in our K8S clusters running Windows containers - it would be great if KRR also worked with the metrics that are output from the prometheus windows_exporter.

This might be as simple as using 'windows_container_cpu_usage_seconds_total' in place of 'container_cpu_usage_seconds_total' and 'windows_container_memory_usage_commit_bytes' in place of 'container_memory_working_set_bytes' though there are possibly other differences that I've not considered to complicate things.

Stretch-goal - support both sets of metric names in parallel, so I get a single report output with all of the containers in the cluster regardless of what OS they're running on.

FYI - the full list of windows container metrics is available here: https://github.com/prometheus-community/windows_exporter/blob/master/docs/collector.container.md

@aantn
Copy link
Contributor

aantn commented Jun 13, 2024

Hi @Rob-B-NAIT,
We are open to PRs for this and I'd be happy to point you in the right direction. Would you be interested in giving it a shot?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants