Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support both user+password AND client cert auth #41

Merged
merged 1 commit into from
Mar 29, 2020

Conversation

cfcs
Copy link
Contributor

@cfcs cfcs commented Mar 28, 2020

Closes #39

@cfcs cfcs requested a review from hannesm March 28, 2020 21:00
@hannesm
Copy link
Contributor

hannesm commented Mar 29, 2020

thanks, esp. for the more in-depth discussion why it can be useful to authenticate via TLS client certificate and user+pass: two-factor authentication with an OTP (see e.g. https://github.com/evgeny-gridasov/openvpn-otp) -- I suspect getting our OpenVPN implementation into shape with OTP will require some more effort (and needs someone with a setup that requires it ;)

@hannesm hannesm merged commit 13b9e2f into master Mar 29, 2020
@hannesm hannesm deleted the both_userpass_and_client_certs branch March 29, 2020 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

its fine to have user/pass AND tls cert auth in client config
2 participants