Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tls-crypt key parsing issues #190

Open
reynir opened this issue Dec 11, 2023 · 0 comments
Open

Tls-crypt key parsing issues #190

reynir opened this issue Dec 11, 2023 · 0 comments

Comments

@reynir
Copy link
Contributor

reynir commented Dec 11, 2023

If the number of characters in a line is odd the last character will be ignored. Lucky for us this means carriage returns will usually be ignored. However, if a line ends with a space and a carriage return this will cause trouble.

The OpenVPN implementation seems to ignore all whitespace. However, it seems they ignore the last hex digit if there is an odd number of total hex digits(!)
https://github.com/OpenVPN/openvpn/blob/f015643fe23d7847ad45b7763f31bfc6baed2159/src/openvpn/crypto.c#L1257-L1289

Originally posted by @reynir in #189 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant