Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactoring: connection establishment #146

Open
hannesm opened this issue Oct 24, 2023 · 0 comments
Open

refactoring: connection establishment #146

hannesm opened this issue Oct 24, 2023 · 0 comments

Comments

@hannesm
Copy link
Contributor

hannesm commented Oct 24, 2023

I noticed the current logic, partially in engine.ml, partially in the effectful implementations (app/miragevpn_client_lwt and mirage/miragevpn_mirage), is pretty similar to what happy-eyeballs-{lwt,mirage} are providing.

This package predates happy-eyeballs. I'd be happy to use happy-eyeballs instead of a partial copy thereof.

There are issues with the current implementation (at least in app/miragevpn_client_lwt with a static_client configuration) that lead (for me after a `Ping_timeout (`Restart _)) to a huge number of connection attempts with no delay in between (that's mostly fine); but once one connection is successful there are still ongoing attempts. to the remote (which never end, since the other side is only accepting a single TCP connection).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant