Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running tests in JS outputs the error twice #1384

Closed
robstoll opened this issue Apr 11, 2023 · 1 comment
Closed

Running tests in JS outputs the error twice #1384

robstoll opened this issue Apr 11, 2023 · 1 comment

Comments

@robstoll
Copy link
Owner

Platform (all, jvm, js): js
Extension (none, kotlin 1.3): none

Code related feature

I guess the culprit is KotlinTestTeamCityConsoleAdapter. We already implemented the a workaround for JVM that we don't see error messages more than once. Maybe we are able to find another workaround for JS as well

For instance:

expect(1) toEqual 2

outputs:

I expected subject: 1        (Int <1>)
◆ to equal: 2        (Int <2>)
I expected subject: 1        (Int <1>)
◆ to equal: 2        (Int <2>)
	at <global>.new AtriumError(/home/robert/projects/atrium/build/js/packages/atrium-atrium-core/kotlin/atrium-atrium-core.js:5429)
	at <global>.createAtriumError(/home/robert/projects/atrium/atrium-core/src/commonMain/kotlin/ch/tutteli/atrium/reporting/AtriumError.kt:26)
	at Companion.create(/home/robert/projects/atrium/atrium-core/src/jsMain/kotlin/ch/tutteli/atrium/reporting/AtriumError.kt:26)
	at RootExpectImpl.append(/home/robert/projects/atrium/atrium-core/src/commonMain/kotlin/ch/tutteli/atrium/creating/impl/RootExpectImpl.kt:69)
	at <global>.toEqual(/home/robert/projects/atrium/logic/atrium-logic/src/commonMain/kotlin/ch/tutteli/atrium/logic/logic.kt:15)
	at ch.tutteli.atrium.reporting.erroradjusters.AdjustStackTest.noOp_containsMochaAndAtrium(/home/robert/projects/atrium/atrium-core/src/jsTest/kotlin/ch/tutteli/atrium/reporting/erroradjusters/AdjustStackTest.kt:21)
	at <global>.fn(kotlin/atrium-atrium-core-test.js:2060)
	at Context.<anonymous>(/home/robert/projects/atrium/build/js/node_modules/src/KotlinTestTeamCityConsoleAdapter.ts:72)
	at <global>.processImmediate(internal/timers.js:456)
@robstoll
Copy link
Owner Author

looks like I overlooked this one when I created #1803, closing as duplicate now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant