Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flexbox support #18

Closed
mscreenie opened this issue Jun 18, 2016 · 3 comments
Closed

Flexbox support #18

mscreenie opened this issue Jun 18, 2016 · 3 comments

Comments

@mscreenie
Copy link

mscreenie commented Jun 18, 2016

Flexbox for centering modals would be excellent and would do away for the need to centering api. Its relatively easy to switch to flexbox plus support has been around for years.

https://caniuse.com/#feat=flexbox

@robinparisi
Copy link
Owner

Hi,

I start working on a POC:

https://codepen.io/robinparisi/pen/VjKGrN?editors=1100

(sticky footer still need JS)

If everything works as it should, I will add it to the next milestone.

@mscreenie
Copy link
Author

mscreenie commented Jun 20, 2016

Here is my current workaround.


.page-flex-modal {

    display: flex!important;
    flex-direction: row;
    flex-wrap: wrap;
    justify-content: center;
    align-content: center;
    align-items: center;
}

.page-flex-modal .tingle-modal-box {
    position: static;
    width: auto;
}

cssClass = page-flex-modal

But width adjusts according to content. Fine in my case but if the user wants to set a percentage through the API they cannot.

Thanks.

@robinparisi
Copy link
Owner

I'm working on it and should push a new version soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants