-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make_request_from_data implementation in RedisMixin #267
Comments
At the time, I'm not sure if current |
IMO, we don't need For the above reason, I don't think that we should add |
I was wonder why the
make_request_from_data
method doesn't just use the more full featuredrequest_from_dict
function from scrapy utils that the queue class in the library already uses? It seems that both do the same thing but even the documentation is a bit misleading when it says:this data can be accessed in scrapy spider through response. like: request.url, request.meta, request.cookies
as nothing outside of
url, method, meta
get set as keyword args anyway.The text was updated successfully, but these errors were encountered: