Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop fruitcake/laravel-cors. Segmentation fault (core dumped) #6

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

vogdb
Copy link

@vogdb vogdb commented Apr 4, 2023

Hi! According to https://github.com/fruitcake/laravel-cors the package is dropped in favor of Laravel's CORS. To be honest I haven't tested these changes. I just followed the "Steps to upgrade:" from README.md of fruitcake/laravel-cors. Feel free to adjust them accordingly.

Currently I receive Segmentation fault (core dumped) after installing this plugin (Winter 1.2.1, PHP 8.1.2, Laravel 9.52). I hoped that dropping of fruitcake will help to overcome this problem.

@vogdb vogdb changed the title Drop fruitcake/laravel-cors Drop fruitcake/laravel-cors. Segmentation fault (core dumped) Apr 4, 2023
@rluders
Copy link
Owner

rluders commented Apr 5, 2023

Thank you. I'll test it later.

@vogdb
Copy link
Author

vogdb commented Apr 6, 2023

I've tested it locally. It doesn't work unfortunately. Still segmentation fault. May be you can advice what I should add here to the PR?

@rluders
Copy link
Owner

rluders commented Apr 6, 2023

@vogdb I'll probably need more info on the error that you are getting. I still had no time to check it. Do you have more info on the error message that you are getting? Sometimes Segmentation faults could be caused by external factors, like server miss config, broken PHP extensions, and many others.

My suggestion to try to identify the cause is to check the error logs and to use xdebug. If you want/have more info to share about it, I'll be happy to give some insights about it.

@vogdb
Copy link
Author

vogdb commented Apr 6, 2023

The only error in the log is:

Use the `composer fund` command to find out more!
> @php artisan winter:version
Segmentation fault (core dumped)
Script @php artisan winter:version handling the post-update-cmd event returned with error code 139

I've tried every possible answer from https://stackoverflow.com/questions/56984159/composer-install-segmentation-fault. Didn't help.

The full log:

wintercms@b35e401ea99e:/var/www/html$ composer require rluders/cors
./composer.json has been updated
Running composer update rluders/cors
Loading composer repositories with package information
Updating dependencies                                 
Lock file operations: 2 installs, 1 update, 0 removals
  - Locking asm89/stack-cors (v2.1.1)
  - Locking fruitcake/laravel-cors (v2.2.0)
  - Upgrading rluders/cors (dev-segfault 0218fc9 => v1.0.6)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 2 installs, 1 update, 0 removals
  - Downloading asm89/stack-cors (v2.1.1)
  - Downloading fruitcake/laravel-cors (v2.2.0)
  - Syncing rluders/cors (v1.0.6) into cache
  - Installing asm89/stack-cors (v2.1.1): Extracting archive
  - Installing fruitcake/laravel-cors (v2.2.0): Extracting archive
  - Removing rluders/cors (dev-segfault 0218fc9)
Deleting plugins/rluders/cors/ - deleted
  - Installing rluders/cors (v1.0.6): Cloning 812a5981e6 from cache
Package fruitcake/laravel-cors is abandoned, you should avoid using it. No replacement was suggested.
Generating autoload files
86 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
> @php artisan winter:version
Segmentation fault (core dumped)
Script @php artisan winter:version handling the post-update-cmd event returned with error code 139

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants