{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":716228772,"defaultBranch":"master","name":"river","ownerLogin":"riverqueue","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2023-11-08T17:43:41.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/136755925?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1725019769.0","currentOid":""},"activityList":{"items":[{"before":"31afef4c4082e0910eefdaeb9dbb3416f7649d21","after":null,"ref":"refs/heads/fix-nil-periodic-jobs","pushedAt":"2024-08-30T12:09:29.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"bgentry","name":"Blake Gentry","path":"/bgentry","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/114033?s=80&v=4"}},{"before":"afcdb5f3f6204f8505abe17e98b49d0a011ad7a2","after":"8669cbc38baf69eeda9dc4eb2944e8ef514d12c7","ref":"refs/heads/master","pushedAt":"2024-08-30T12:09:28.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"bgentry","name":"Blake Gentry","path":"/bgentry","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/114033?s=80&v=4"},"commit":{"message":"Fix nil periodic jobs (#572)\n\n* Do not insert a new job if PeriodicJobConstructor returns nil\r\n\r\nThis commit fixes an issue with the PerioridJobConstructor ignoring the\r\nreturn value. According to the docs, we should ignore the job is nil is\r\nreturned.\r\n\r\n* Remove unused struct\r\n\r\n* add client-level test coverage for PeriodicJobConstructor nil return\r\n\r\n---------\r\n\r\nCo-authored-by: Andriy Semenets <semanser@gmail.com>","shortMessageHtmlLink":"Fix nil periodic jobs (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2496018179\" data-permission-text=\"Title is private\" data-url=\"https://github.com/riverqueue/river/issues/572\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/riverqueue/river/pull/572/hovercard\" href=\"https://github.com/riverqueue/river/pull/572\">#572</a>)"}},{"before":"19af887b3879d79304292e0d9c695e8364aeb9f1","after":null,"ref":"refs/heads/bg-doc-improvements","pushedAt":"2024-08-30T05:32:28.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"bgentry","name":"Blake Gentry","path":"/bgentry","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/114033?s=80&v=4"}},{"before":"19a925d6fe58adb2e1116bd853d2183027223754","after":"afcdb5f3f6204f8505abe17e98b49d0a011ad7a2","ref":"refs/heads/master","pushedAt":"2024-08-30T05:32:27.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"bgentry","name":"Blake Gentry","path":"/bgentry","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/114033?s=80&v=4"},"commit":{"message":"minor documentation improvements (#571)","shortMessageHtmlLink":"minor documentation improvements (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2496005817\" data-permission-text=\"Title is private\" data-url=\"https://github.com/riverqueue/river/issues/571\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/riverqueue/river/pull/571/hovercard\" href=\"https://github.com/riverqueue/river/pull/571\">#571</a>)"}},{"before":"c10df067cc6e18bfe49831d692c127dbc31c7600","after":"31afef4c4082e0910eefdaeb9dbb3416f7649d21","ref":"refs/heads/fix-nil-periodic-jobs","pushedAt":"2024-08-30T02:48:31.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"bgentry","name":"Blake Gentry","path":"/bgentry","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/114033?s=80&v=4"},"commit":{"message":"add client-level test coverage for PeriodicJobConstructor nil return","shortMessageHtmlLink":"add client-level test coverage for PeriodicJobConstructor nil return"}},{"before":"5dc000432791cd81070a25a483e4f79985dfb460","after":"c10df067cc6e18bfe49831d692c127dbc31c7600","ref":"refs/heads/fix-nil-periodic-jobs","pushedAt":"2024-08-30T02:47:08.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"bgentry","name":"Blake Gentry","path":"/bgentry","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/114033?s=80&v=4"},"commit":{"message":"add client-level test coverage for PeriodicJobConstructor nil return","shortMessageHtmlLink":"add client-level test coverage for PeriodicJobConstructor nil return"}},{"before":"023a7ae79ea6a732f9d4c190c4a2a156a392ae88","after":"5dc000432791cd81070a25a483e4f79985dfb460","ref":"refs/heads/fix-nil-periodic-jobs","pushedAt":"2024-08-30T02:46:38.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"bgentry","name":"Blake Gentry","path":"/bgentry","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/114033?s=80&v=4"},"commit":{"message":"add client-level test coverage for PeriodicJobConstructor nil return","shortMessageHtmlLink":"add client-level test coverage for PeriodicJobConstructor nil return"}},{"before":null,"after":"023a7ae79ea6a732f9d4c190c4a2a156a392ae88","ref":"refs/heads/fix-nil-periodic-jobs","pushedAt":"2024-08-30T02:42:55.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"bgentry","name":"Blake Gentry","path":"/bgentry","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/114033?s=80&v=4"},"commit":{"message":"add client-level test coverage for PeriodicJobConstructor nil return","shortMessageHtmlLink":"add client-level test coverage for PeriodicJobConstructor nil return"}},{"before":null,"after":"19af887b3879d79304292e0d9c695e8364aeb9f1","ref":"refs/heads/bg-doc-improvements","pushedAt":"2024-08-30T02:31:58.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"bgentry","name":"Blake Gentry","path":"/bgentry","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/114033?s=80&v=4"},"commit":{"message":"minor documentation improvements","shortMessageHtmlLink":"minor documentation improvements"}},{"before":"f97b6018bf07d57f43b5d6d0c53a54f935939f7d","after":null,"ref":"refs/heads/bg-insert-tx-doc-improvement","pushedAt":"2024-08-29T16:11:58.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"bgentry","name":"Blake Gentry","path":"/bgentry","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/114033?s=80&v=4"}},{"before":"958d4a6139bfc5f290ecb9fc204e0c2f186c0df9","after":"19a925d6fe58adb2e1116bd853d2183027223754","ref":"refs/heads/master","pushedAt":"2024-08-29T16:11:57.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"bgentry","name":"Blake Gentry","path":"/bgentry","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/114033?s=80&v=4"},"commit":{"message":"improve InsertTx documentation (#569)\n\nI got this feedback from a River Pro customer who mentioned that we had\r\na better explanation of the reasons to use `InsertTx` on the docs\r\nwebsite than we had in the godoc. This attempts to bridge that gap by\r\nproviding a better explanation in the method comments.","shortMessageHtmlLink":"improve InsertTx documentation (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2492438946\" data-permission-text=\"Title is private\" data-url=\"https://github.com/riverqueue/river/issues/569\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/riverqueue/river/pull/569/hovercard\" href=\"https://github.com/riverqueue/river/pull/569\">#569</a>)"}},{"before":"11c3b12703a43becc40c48cbd60cf277e705e13b","after":null,"ref":"refs/heads/bg-fix-set-state-if-running-query-bug","pushedAt":"2024-08-28T15:35:02.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"bgentry","name":"Blake Gentry","path":"/bgentry","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/114033?s=80&v=4"}},{"before":"bbb4a985ce80674a092aa3dbfc07b7b954ce7e93","after":"958d4a6139bfc5f290ecb9fc204e0c2f186c0df9","ref":"refs/heads/master","pushedAt":"2024-08-28T15:35:01.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"bgentry","name":"Blake Gentry","path":"/bgentry","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/114033?s=80&v=4"},"commit":{"message":"also clear unique_key when should_cancel (#560)\n\nWhile doing some work on a related query, I noticed that the\r\n`unique_key` is being cleared here specifically if the new state is\r\nexplicitly `cancelled`, but _not_ if the state is being set to cancel\r\nbecause of a cancellation attempt that didn't get picked up before the\r\njob completed.\r\n\r\nI didn't yet add test coverage for this but wanted to at least commit it\r\nbefore I forgot.","shortMessageHtmlLink":"also clear unique_key when should_cancel (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2483686991\" data-permission-text=\"Title is private\" data-url=\"https://github.com/riverqueue/river/issues/560\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/riverqueue/river/pull/560/hovercard\" href=\"https://github.com/riverqueue/river/pull/560\">#560</a>)"}},{"before":null,"after":"f97b6018bf07d57f43b5d6d0c53a54f935939f7d","ref":"refs/heads/bg-insert-tx-doc-improvement","pushedAt":"2024-08-28T15:33:27.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"bgentry","name":"Blake Gentry","path":"/bgentry","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/114033?s=80&v=4"},"commit":{"message":"improve InsertTx documentation\n\nI got this feedback from a River Pro customer who mentioned that we had\na better explanation of the reasons to use `InsertTx` on the docs\nwebsite than we had in the godoc. This attempts to bridge that gap by\nproviding a better explanation in the method comments.","shortMessageHtmlLink":"improve InsertTx documentation"}},{"before":"06bbfdc43ffd3f8019060f049dc61b6ad52c1ff8","after":"11c3b12703a43becc40c48cbd60cf277e705e13b","ref":"refs/heads/bg-fix-set-state-if-running-query-bug","pushedAt":"2024-08-28T15:31:50.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"bgentry","name":"Blake Gentry","path":"/bgentry","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/114033?s=80&v=4"},"commit":{"message":"also clear unique_key when should_cancel\n\nWhile doing some work on a related query, I noticed that the\n`unique_key` is being cleared here specifically if the new state is\nexplicitly `cancelled`, but _not_ if the state is being set to cancel\nbecause of a cancellation attempt that didn't get picked up before the\njob completed.\n\nI didn't yet add test coverage for this but wanted to at least commit it\nbefore I forgot.","shortMessageHtmlLink":"also clear unique_key when should_cancel"}},{"before":"231d82115166a642f02fd5ef864d71f4622c8647","after":"bbb4a985ce80674a092aa3dbfc07b7b954ce7e93","ref":"refs/heads/master","pushedAt":"2024-08-28T12:01:20.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"brandur","name":"Brandur Leach","path":"/brandur","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/96890?s=80&v=4"},"commit":{"message":"Update README.md (#568)\n\nStandardizes the codeblocks (noticed one was missing a language tag).","shortMessageHtmlLink":"Update README.md (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2487563950\" data-permission-text=\"Title is private\" data-url=\"https://github.com/riverqueue/river/issues/568\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/riverqueue/river/pull/568/hovercard\" href=\"https://github.com/riverqueue/river/pull/568\">#568</a>)"}},{"before":"176c8532666e5a0849bb0f05424ba86150507632","after":null,"ref":"refs/heads/brandur-work-context","pushedAt":"2024-08-26T14:05:33.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"brandur","name":"Brandur Leach","path":"/brandur","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/96890?s=80&v=4"}},{"before":"65fd8158aa6c4dd51558bb62cc4b3ce0f74de47a","after":"231d82115166a642f02fd5ef864d71f4622c8647","ref":"refs/heads/master","pushedAt":"2024-08-26T14:05:30.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"brandur","name":"Brandur Leach","path":"/brandur","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/96890?s=80&v=4"},"commit":{"message":"Add `rivertest.WorkContext` for use testing `JobArgs.Work` implementations (#526)\n\nHere, add a new test helper called `rivertest.WorkContext`. Its purpose\r\nis to generate a realistic looking context for testing `JobArgs.Work`\r\nimplementation, particularly by adding a client to context that makes\r\n`river.ClientFromContext` available in tests, but may also be used to\r\nadd any other context-related features that may be added in the future.\r\n\r\nWe've talked about new test helpers for running `Work` implementations\r\nand may still do that, but this is a primitive that makes testing a\r\nlittle better without having to add anything heavyweight.","shortMessageHtmlLink":"Add <code>rivertest.WorkContext</code> for use testing <code>JobArgs.Work</code> implementa…"}},{"before":"78de0f6b8ecae014d7a350c5e17cafea48fe1698","after":"176c8532666e5a0849bb0f05424ba86150507632","ref":"refs/heads/brandur-work-context","pushedAt":"2024-08-24T22:52:34.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"brandur","name":"Brandur Leach","path":"/brandur","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/96890?s=80&v=4"},"commit":{"message":"Add `rivertest.WorkContext` for use testing `JobArgs.Work` implementations\n\nHere, add a new test helper called `rivertest.WorkContext`. Its purpose\nis to generate a realistic looking context for testing `JobArgs.Work`\nimplementation, particularly by adding a client to context that makes\n`river.ClientFromContext` available in tests, but may also be used to\nadd any other context-related features that may be added in the future.\n\nWe've talked about new test helpers for running `Work` implementations\nand may still do that, but this is a primitive that makes testing a\nlittle better without having to add anything heavyweight.","shortMessageHtmlLink":"Add <code>rivertest.WorkContext</code> for use testing <code>JobArgs.Work</code> implementa…"}},{"before":"18d35711f0cf7529d7c5fa49aa927a2537dee35a","after":null,"ref":"refs/heads/brandur-better-handle-non-existent-line","pushedAt":"2024-08-24T22:38:04.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"brandur","name":"Brandur Leach","path":"/brandur","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/96890?s=80&v=4"}},{"before":"7270b5e5dd70ac111dd00f09b889ab52dbe99f1b","after":"65fd8158aa6c4dd51558bb62cc4b3ce0f74de47a","ref":"refs/heads/master","pushedAt":"2024-08-24T22:38:03.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"brandur","name":"Brandur Leach","path":"/brandur","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/96890?s=80&v=4"},"commit":{"message":"Better handle non-existent migration line + suggestions with Levenshtein distance (#558)\n\nThis is related to #546. That was a documentation problem, but there are\r\nsome code problems that are related.\r\n\r\nThe first is that an unknown migration line is a panic in the CLI. This\r\nis a byproduct of the fact that `rivermigrate.New` checks the migration\r\nline name, but doesn't return an error, so it'd panic instead.\r\n\r\nHere, I'm suggesting that we do a small breaking change by having\r\n`rivermigrate.New` return a possible error. It's not great, but it's\r\nsomething that'll easy for people to fix, and might help avoid some\r\nfuture panics. An alternative possibility would be to add a new\r\n`NewWithError` or something of that nature, but it'd make the API a\r\nlittle uglier.\r\n\r\nAlong with that change, we also bring in a change to suggest migration\r\nlines in case of an unknown one using Levenshtein distances. This is\r\naimed at preventing totally unactionable errors in the event of very\r\nsimple misspellings (e.g. \"workflow\" versus \"workflows\"). Cobra actually\r\nalready has a similar feature built-in for command misspellings.\r\n\r\nI vendored in this repo [1] as a Levenshtein implementation and did a\r\nlittle code clean up. I don't want to add another Go module dependency\r\nfor such a simple algorithm (it's just a dozen lines), and I believe\r\ntheir MIT license should be compatible.\r\n\r\n[1] https://github.com/agnivade/levenshtein/tree/master","shortMessageHtmlLink":"Better handle non-existent migration line + suggestions with Levensht…"}},{"before":"8307465fea5c37a6a58fc6d347afb258efd21d89","after":null,"ref":"refs/heads/bg-sqlc-v1.27","pushedAt":"2024-08-24T22:05:19.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"bgentry","name":"Blake Gentry","path":"/bgentry","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/114033?s=80&v=4"}},{"before":"b4b778cd2f822488f8a127cbaa6e8a4167f51fdf","after":"7270b5e5dd70ac111dd00f09b889ab52dbe99f1b","ref":"refs/heads/master","pushedAt":"2024-08-24T22:05:17.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"bgentry","name":"Blake Gentry","path":"/bgentry","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/114033?s=80&v=4"},"commit":{"message":"sqlc v1.27 (#561)","shortMessageHtmlLink":"sqlc v1.27 (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2483687832\" data-permission-text=\"Title is private\" data-url=\"https://github.com/riverqueue/river/issues/561\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/riverqueue/river/pull/561/hovercard\" href=\"https://github.com/riverqueue/river/pull/561\">#561</a>)"}},{"before":"6e3c25eeb1d36412620e613202b944b869d62a11","after":"18d35711f0cf7529d7c5fa49aa927a2537dee35a","ref":"refs/heads/brandur-better-handle-non-existent-line","pushedAt":"2024-08-24T21:56:19.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"brandur","name":"Brandur Leach","path":"/brandur","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/96890?s=80&v=4"},"commit":{"message":"Better handle non-existent migration line + suggestions with Levenshtein distance\n\nThis is related to #546. That was a documentation problem, but there are\nsome code problems that are related.\n\nThe first is that an unknown migration line is a panic in the CLI. This\nis a byproduct of the fact that `rivermigrate.New` checks the migration\nline name, but doesn't return an error, so it'd panic instead.\n\nHere, I'm suggesting that we do a small breaking change by having\n`rivermigrate.New` return a possible error. It's not great, but it's\nsomething that'll easy for people to fix, and might help avoid some\nfuture panics. An alternative possibility would be to add a new\n`NewWithError` or something of that nature, but it'd make the API a\nlittle uglier.\n\nAlong with that change, we also bring in a change to suggest migration\nlines in case of an unknown one using Levenshtein distances. This is\naimed at preventing totally unactionable errors in the event of very\nsimple misspellings (e.g. \"workflow\" versus \"workflows\"). Cobra actually\nalready has a similar feature built-in for command misspellings.\n\nI vendored in this repo [1] as a Levenshtein implementation and did a\nlittle code clean up. I don't want to add another Go module dependency\nfor such a simple algorithm (it's just a dozen lines), and I believe\ntheir MIT license should be compatible.\n\n[1] https://github.com/agnivade/levenshtein/tree/master","shortMessageHtmlLink":"Better handle non-existent migration line + suggestions with Levensht…"}},{"before":"b471ce5256fcf6514a4bb9cc083a31d80f77cac6","after":"6e3c25eeb1d36412620e613202b944b869d62a11","ref":"refs/heads/brandur-better-handle-non-existent-line","pushedAt":"2024-08-24T21:53:47.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"brandur","name":"Brandur Leach","path":"/brandur","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/96890?s=80&v=4"},"commit":{"message":"Better handle non-existent migration line + suggestions with Levenshtein distance\n\nThis is related to #546. That was a documentation problem, but there are\nsome code problems that are related.\n\nThe first is that an unknown migration line is a panic in the CLI. This\nis a byproduct of the fact that `rivermigrate.New` checks the migration\nline name, but doesn't return an error, so it'd panic instead.\n\nHere, I'm suggesting that we do a small breaking change by having\n`rivermigrate.New` return a possible error. It's not great, but it's\nsomething that'll easy for people to fix, and might help avoid some\nfuture panics. An alternative possibility would be to add a new\n`NewWithError` or something of that nature, but it'd make the API a\nlittle uglier.\n\nAlong with that change, we also bring in a change to suggest migration\nlines in case of an unknown one using Levenshtein distances. This is\naimed at preventing totally unactionable errors in the event of very\nsimple misspellings (e.g. \"workflow\" versus \"workflows\"). Cobra actually\nalready has a similar feature built-in for command misspellings.\n\nI vendored in this repo [1] as a Levenshtein implementation and did a\nlittle code clean up. I don't want to add another Go module dependency\nfor such a simple algorithm (it's just a dozen lines), and I believe\ntheir MIT license should be compatible.\n\n[1] https://github.com/agnivade/levenshtein/tree/master","shortMessageHtmlLink":"Better handle non-existent migration line + suggestions with Levensht…"}},{"before":"35623ec3b364d71a9563666d19eea009aef5b1fa","after":null,"ref":"refs/heads/brandur-preinit-work-cancel","pushedAt":"2024-08-24T21:44:55.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"brandur","name":"Brandur Leach","path":"/brandur","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/96890?s=80&v=4"}},{"before":"394aa6879e2c2a32ca9652de9b719c30fb2c272a","after":"b4b778cd2f822488f8a127cbaa6e8a4167f51fdf","ref":"refs/heads/master","pushedAt":"2024-08-24T21:44:53.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"brandur","name":"Brandur Leach","path":"/brandur","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/96890?s=80&v=4"},"commit":{"message":"Preinitialize `workCancel` function in case `StopAndCancel` called before start (#557)\n\nThis one's related to #549. Although the most proximate problem in that\r\nrepro code is that there was no error check when calling `Start`, it did\r\nreveal a legitimate problem in that the River client will panic in case\r\n`StopAndCancel` is called before `Start` because `workCancel` was never\r\nset.\r\n\r\nHere, initialize `workCancel` in the client's constructor. During normal\r\noperation this will be overwritten almost immediately on `Start` as the\r\nclient starts up, but in case `Start` was never called or didn't run\r\nsuccessfully, it provides a function for `StopAndCancel` to call so that\r\nit doesn't panic.\r\n\r\nFixes #549.","shortMessageHtmlLink":"Preinitialize <code>workCancel</code> function in case <code>StopAndCancel</code> called be…"}},{"before":"4886b7316f71e0bb2200d297472f495b99f95e38","after":"35623ec3b364d71a9563666d19eea009aef5b1fa","ref":"refs/heads/brandur-preinit-work-cancel","pushedAt":"2024-08-24T21:42:12.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"brandur","name":"Brandur Leach","path":"/brandur","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/96890?s=80&v=4"},"commit":{"message":"Preinitialize `workCancel` function in case `StopAndCancel` called before start\n\nThis one's related to #549. Although the most proximate problem in that\nrepro code is that there was no error check when calling `Start`, it did\nreveal a legitimate problem in that the River client will panic in case\n`StopAndCancel` is called before `Start` because `workCancel` was never\nset.\n\nHere, initialize `workCancel` in the client's constructor. During normal\noperation this will be overwritten almost immediately on `Start` as the\nclient starts up, but in case `Start` was never called or didn't run\nsuccessfully, it provides a function for `StopAndCancel` to call so that\nit doesn't panic.\n\nFixes #549.","shortMessageHtmlLink":"Preinitialize <code>workCancel</code> function in case <code>StopAndCancel</code> called be…"}},{"before":"20ba899480b1e2a701aeb327a23f1eaa2c801455","after":"06bbfdc43ffd3f8019060f049dc61b6ad52c1ff8","ref":"refs/heads/bg-fix-set-state-if-running-query-bug","pushedAt":"2024-08-23T18:48:08.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"bgentry","name":"Blake Gentry","path":"/bgentry","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/114033?s=80&v=4"},"commit":{"message":"also clear unique_key when should_cancel\n\nWhile doing some work on a related query, I noticed that the\n`unique_key` is being cleared here specifically if the new state is\nexplicitly `cancelled`, but _not_ if the state is being set to cancel\nbecause of a cancellation attempt that didn't get picked up before the\njob completed.\n\nI didn't yet add test coverage for this but wanted to at least commit it\nbefore I forgot.","shortMessageHtmlLink":"also clear unique_key when should_cancel"}},{"before":null,"after":"8307465fea5c37a6a58fc6d347afb258efd21d89","ref":"refs/heads/bg-sqlc-v1.27","pushedAt":"2024-08-23T18:47:30.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"bgentry","name":"Blake Gentry","path":"/bgentry","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/114033?s=80&v=4"},"commit":{"message":"sqlc v1.27","shortMessageHtmlLink":"sqlc v1.27"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEqJ-UOQA","startCursor":null,"endCursor":null}},"title":"Activity · riverqueue/river"}