-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does not build #9
Comments
Hi.. Could you tell me which example you are trying to run? I notice that the |
Sorry, coulda been more specific. I get the error when running |
I believe the examples are not up to date anymore indeed. The |
Also seeing this error when I add |
Hey, so I managed to compile by pulling the code out of lsh-rs/lsh-rs/src/ and copying into my src, with some module changes.. you can see this commit here if it's helpful bwindsor22/thistle@477cd93 As an aside, for vector similarity lookup, you might also check out granne, hnswlib-rs, and hnsw libraries |
@ritchie46 thanks for the comment on blas, was helpful -- thoughts on shipping the examples separately? Something like Cargo.toml -> RemoveMe.Cargo.toml for a quick fix |
@ritchie46 err, looking back, some of the errors that @ijsnow saw were things I fixed locally -- e.g. changing this to std::marker::PhantomData 8 | use serde::export::PhantomData; |
... however when git clone and cargo make locally, I do get the blas error. So I think the blas error is an issue, but as I can get the code to compile without solving it, it might be possible to ship a working version of this lib only by quarantining the blas bit and separately solving the serde errors ijsnow was seeing |
Yes, that's definitly a good one. Could you make a PR for that fix? |
This make sense, BLAS is only for squeezing out max performance, but should definitely be opt in. |
Great, submitted. |
I'm trying to run the examples and it seems like the project doesn't build at the moment. The compiler is reporting a few places where what appears to be a private
serde
module is being used. Did serde update and remove that export? Or am I missing something in order to import private modules?The text was updated successfully, but these errors were encountered: