Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catalog: remove the is_primary field from the ColumnDesc #385

Open
st1page opened this issue Jan 30, 2022 · 0 comments
Open

catalog: remove the is_primary field from the ColumnDesc #385

st1page opened this issue Jan 30, 2022 · 0 comments

Comments

@st1page
Copy link
Collaborator

st1page commented Jan 30, 2022

now we have the the definitions:

pub struct ColumnDesc {
    datatype: DataType,
    is_primary: bool,
}
pub struct ColumnCatalog {
    id: ColumnId,
    name: String,
    desc: ColumnDesc,
}

remove the is_primiary field from the ColumnDesc, and add the primiary_column: ColumnId in SecondaryTable and TableCatalog

@st1page st1page changed the title catalog: refactor ColumnCatalog and ColumnDesc catalog: remove the is_primiary field from the ColumnDesc Jan 30, 2022
@TennyZhuang TennyZhuang changed the title catalog: remove the is_primiary field from the ColumnDesc catalog: remove the is_primary field from the ColumnDesc Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant