feat: Map from source object #1247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
latonz
requested changes
Apr 24, 2024
...Riok.Mapperly/Descriptors/MappingBodyBuilders/BuilderContext/MembersMappingBuilderContext.cs
Outdated
Show resolved
Hide resolved
src/Riok.Mapperly/Descriptors/Mappings/MemberMappings/MemberExistingTargetMapping.cs
Outdated
Show resolved
Hide resolved
latonz
requested changes
Apr 24, 2024
a041f5f
to
f62b46b
Compare
latonz
requested changes
Apr 30, 2024
There was a problem hiding this comment.
Thanks for the updates 😊 Only open feedback point: #1247 (comment).
latonz
approved these changes
May 3, 2024
|
Thank you for this great addition to Mapperly! |
|
🎉 This PR is included in version 3.6.0-next.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.6.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow mapping from source object
Description
Adds a
MapPropertyFromSourceAttribute, that allows using the source object directly for mappings. In most of the code, this is represented as an empty sourceMemberPath. This required a few changes, as most of the code just assumedMemberPaths were not empty. Currently, when aMapPropertyFromSourceAttributeis used, all unused source member diagnostics are suppressed, as there is no way to analyse for every situation what members of the source are used by the conversion. This can be changed to require explicit ignore attributes for all members that are used implicitly by the mapping from source.An additional reason for wanting this, apart from the arguments discussed in #1161, is to allow these kind of mappings for required or init-only members.
Fixes #1161
Checklist