Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When events are overlap , delegate method is called for least event #364

Open
nickp4488 opened this issue Dec 28, 2023 · 1 comment
Open
Labels

Comments

@nickp4488
Copy link

nickp4488 commented Dec 28, 2023

Hello, thanks a lot for awesome Library @richardtop!

Recently, I implemented this library in my project & got an issue as follow

Example : Event1 : start 12 AM to 11 PM (Blue)
Event2: start 1:30 AM to 1:40 AM (Orange)

When both events are overlap & eventsWillOverlap = true,
the delegate method is just call for event1 , instead of event 2.

If I set eventsWillOverlap = false & try to tap on event, it is working fine.

Screenshot 2023-12-28 at 11 16 01 PM

Am I doing any mistake here?

How can we achieve to call top most event for delegate call.

@nickp4488 nickp4488 added the bug label Dec 28, 2023
@nickp4488 nickp4488 changed the title When events are overlap , delegate method is called for lest event When events are overlap , delegate method is called for least event Dec 28, 2023
@richardtop
Copy link
Owner

Hello, could you please provide the sample code to reproduce the issue? I.e. create a sample project and/or just list your DayViewController with minimal amount of code to reproduce it.

From my point of view, the delegate method should be called for the "topmost" event. i.e. since the larger (longer) event is in the background and can be tapped at other positions (e.g. 12:30 AM), the smaller (shorter) events should take the priority.

From my perspective, this is a bug in the library.
Looking forward to more thoughts from you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants